-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add T-SQL verification queries #876
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to have meaningful filenames
Yes, that would be better. Right now, it just uses the example file name. However, it will make the process more complex and require another LLM inference step to generate the filenames based on the content. Can we skip it unless absolutely required? |
I think it is OK to leave this - it is already a massive PR because of the huge number of examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's impossible to check all examples in a review but that is just how it has to be unfortunately.
@bishwajit-db I've made a note on the issue so that we have a placeholder to add the Databricks version of all of these, so that we can go ahead and merge this and then work on the other part on a separate PR. |
Add T-SQL verification queries. Resolves #636