Fix precedence of CTEs with respect to set operations in SnowFlake #1273
Conversation
asnare
added
bug
|
Looks like some of the functional tests have cosmetic differences with the Python versions, specifically extra parentheses when transpiling set operations. I'll move the affected tests into the core-specific test set. |
| | a * t.d | ||
| |FROM t;""".stripMargin transpilesTo | ||
| "Common Table Expressions (CTEs)" should { | ||
| """support expressions""" in { |
There was a problem hiding this comment.
would "have precedence" be better ?
Not sure we want to drop the python tests altogether, notably n the light of the Multiplexer MVP scope ? |
Move those tests under |
| -- databricks sql: | ||
| WITH a AS (SELECT 1, 2, 3) | ||
|
|
||
| (SELECT 4, 5, 6) |
There was a problem hiding this comment.
I'm not sure the parenthesis are required here
| WITH a AS (SELECT 1, 2, 3), | ||
| b AS (SELECT 4, 5, 6), | ||
| c AS (SELECT * FROM a) | ||
| (SELECT * from b) |
There was a problem hiding this comment.
I'm not sure the parenthesis are required here
| -- databricks sql: | ||
| WITH a AS (SELECT 1, 2, 3) | ||
|
|
||
| (SELECT 4, 5, 6) |
There was a problem hiding this comment.
I'm not sure the parenthesis are required here
| WITH a AS (SELECT 1, 2, 3), | ||
| b AS (SELECT 4, 5, 6), | ||
| c AS (SELECT * FROM a) | ||
| (SELECT * from b) |
There was a problem hiding this comment.
I'm not sure the parenthesis are required here
…ine. The python implementation fails due to some cosmetic differences in the output.
This PR fixes the handling of CTEs with respect to set operations; prior to this the CTE was associated with only the first
SELECTin the sequence of set operations instead of the entire set.Incidental changes:
Resolves: #1267