-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop plan parser dependency on antlr4 #1201
base: refactor-parsing-pipeline
Are you sure you want to change the base?
Drop plan parser dependency on antlr4 #1201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making this less generic will force reimplementation of code in the specific plan parsers. I don't think that this is a good idea. Dependency on ANTLR is not really a problem for the parser I think.
Perhaps you can explain why you want to dothis?
I agree it's not a big problem (yet) however:
|
Our current PlanParser enforces use of ANTLR4 to parse input.
This dependency is undesirable, and does not provide any benefit.
Thanks to #1200, this is no longer required.
This PR:
Removes dependency on antlr4 in PlanParser
Requires #1200
Progresses #869
Supersedes #1192