Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in BNG lettermap #433

Merged

Conversation

tompeterken-os
Copy link
Contributor

@tompeterken-os tompeterken-os commented Sep 19, 2023

The tile SZ appears twice in letterMap in BNGIndexSystem.scala. One instance should read "HZ" instead. As a result, features in the HZ square are given "SZ" grid indices.

This PR makes a single update to letterMap, correcting the typo.

(Probably not spotted before now because only Fair Isle appears in the HZ square!)

Signed-off by Tom Peterken [email protected]

@milos-colic
Copy link
Contributor

Hi @tompeterken-os , in order for us to proceed it is sufficient to add a comment to this PR with your sign-off (Eg. Signed-off-by: Joe Smith <[email protected]>).
We need this to make sure you are aware of the current license, and that you agree with it. :)

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #433 (e69fb94) into main (19f2e9f) will increase coverage by 0.01%.
Report is 160 commits behind head on main.
The diff coverage is 97.56%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   95.01%   95.02%   +0.01%     
==========================================
  Files         198      198              
  Lines        5658     5692      +34     
  Branches      178      175       -3     
==========================================
+ Hits         5376     5409      +33     
- Misses        282      283       +1     
Files Coverage Δ
...bricks/labs/mosaic/core/index/BNGIndexSystem.scala 99.01% <100.00%> (ø)
...abricks/labs/mosaic/core/index/H3IndexSystem.scala 97.59% <97.50%> (-0.37%) ⬇️

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sllynn sllynn changed the base branch from main to pre-0.4.3-release September 24, 2024 09:32
@sllynn sllynn merged commit bef8c1b into databrickslabs:pre-0.4.3-release Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants