Add support for cellFormat in TableV1ColumnEncoding #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishwajit-db
temporarily deployed
to
runtime
GitHub Actions
Inactive
|
✅ 35/35 passed, 4 skipped, 20m59s total Running from acceptance #422 |
nfx
pushed a commit
to databrickslabs/remorph
that referenced
this pull request
Oct 2, 2024
closes #708 The existing dashboard has been broken into 2. For features unsupported by LSQL, we are using overrides to implement the required widgets. Conditional formatting depends on databrickslabs/lsql#299 Screenshots:   -- co-authored by @bishwajit-db and @sundarshankar89 --------- Co-authored-by: Bishwajit <[email protected]>
|
@nfx this needs your attention |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for cellFormat in TableV1ColumnEncoding.
Although the models.py file is autogenerated, this PR tries to manually add support for cellFormat in TableV1ColumnEncoding. It can be considered a temporary solution until a new model.py file is generated.
cellFormat is required by some dashboard implementations for conditional formatting.
Ref: databrickslabs/remorph#768
Can we proceed with it?