Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data ranges for random data generation #298

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

ghanse
Copy link
Contributor

@ghanse ghanse commented Jul 26, 2024

Proposed changes

Bugfix for random generation when maxValue is not specified or implied from ColumnSpecOptions. RELATED ISSUE

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to tutorials, tests or examples
  • Non code change (readme, images or other non-code assets)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Submission does not reduce code coverage numbers
  • Submission does not increase alerts or messages from prospector / lint

Further comments

I added default min or max values to the column generation options when not explicitly specified.

@ghanse ghanse requested a review from a team as a code owner July 26, 2024 19:51
@ghanse ghanse requested review from ronanstokes-db and removed request for a team July 26, 2024 19:51
Copy link
Collaborator

@ronanstokes-db ronanstokes-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronanstokes-db ronanstokes-db merged commit a9a7778 into databrickslabs:master Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants