Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature standard datasets - part 2 #286

Merged

Conversation

ghanse
Copy link
Contributor

@ghanse ghanse commented Jun 7, 2024

Proposed changes

Added the following standard datasets:

  • basic/geometries - Simulates WKT geometry representations; Supports POINT, LINESTRING, and POLYGON types
  • basic/process_historian - Simulates time-series data from manufacturing systems
  • basic/telematics - Simulates time-series data from GPS tracking systems
  • benchmark/groupby - A benchmarking dataset with grouping columns and values of various data types

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to tutorials, tests or examples
  • Non code change (readme, images or other non-code assets)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Submission does not reduce code coverage numbers
  • Submission does not increase alerts or messages from prospector / lint

Further comments

N/A

@ghanse ghanse requested a review from a team as a code owner June 7, 2024 16:55
@ghanse ghanse requested review from ronanstokes-db and removed request for a team June 7, 2024 16:55
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 88.32487% with 23 lines in your changes missing coverage. Please review.

Project coverage is 92.39%. Comparing base (da1df6b) to head (7c77e2a).

Current head 7c77e2a differs from pull request most recent head e7a6216

Please upload reports for the commit e7a6216 to get more accurate results.

Files Patch % Lines
dbldatagen/datasets/basic_telematics.py 81.25% 8 Missing and 4 partials ⚠️
dbldatagen/datasets/basic_process_historian.py 82.92% 6 Missing and 1 partial ⚠️
dbldatagen/datasets/basic_geometries.py 95.91% 1 Missing and 1 partial ⚠️
dbldatagen/datasets/benchmark_groupby.py 94.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage   92.63%   92.39%   -0.24%     
==========================================
  Files          38       42       +4     
  Lines        3380     3577     +197     
  Branches      589      631      +42     
==========================================
+ Hits         3131     3305     +174     
- Misses        141      158      +17     
- Partials      108      114       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check grouping ratios compared with original benchmark but if fix needed, you can create separate pr for that

Copy link
Contributor

@ronanstokes-db ronanstokes-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good

@ronanstokes-db ronanstokes-db added the enhancement New feature or request label Jun 7, 2024
added space to line 147 to pass lint checks
@ronanstokes-db ronanstokes-db merged commit 4206b5c into databrickslabs:master Jun 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants