Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature standard datasets - part 2 #280

Conversation

ghanse
Copy link
Contributor

@ghanse ghanse commented Jun 6, 2024

Proposed changes

  • basic/geometries - Creates a set of geometries represented as WKT
  • basic/process_historian - Simulates process historian data with device ID, timestamp, tag, and value
  • basic/telematics - Simulates GPS tracking data with device ID, timestamp, latitude, longitude, and heading
  • benchmark/groupby - A benchmarking dataset with IDs, groups, and values of various types

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to tutorials, tests or examples
  • Non code change (readme, images or other non-code assets)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Submission does not reduce code coverage numbers
  • Submission does not increase alerts or messages from prospector / lint

Further comments

N/A

@ghanse ghanse requested a review from a team as a code owner June 6, 2024 18:45
@ghanse ghanse requested review from ronanstokes-db and removed request for a team June 6, 2024 18:45
@CLAassistant
Copy link

CLAassistant commented Jun 6, 2024

CLA assistant check
All committers have signed the CLA.

@ronanstokes-db ronanstokes-db changed the base branch from feature_test_pr to feature_standard_datasets June 6, 2024 19:49
@ghanse ghanse changed the title Feature standard datasets Feature standard datasets - part 2 Jun 6, 2024
Copy link
Contributor

@ronanstokes-db ronanstokes-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - lets see if tests pass and there is sufficient coverage

@ronanstokes-db ronanstokes-db deleted the branch databrickslabs:feature_standard_datasets June 7, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants