Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature standard datasets - part 1 #258

Merged
merged 81 commits into from
Jun 7, 2024
Merged

Conversation

ronanstokes-db
Copy link
Contributor

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers.
If it fixes a bug or resolves a feature request, please provide a link to that issue.

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to tutorials, tests or examples
  • Non code change (readme, images or other non-code assets)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Submission does not reduce code coverage numbers
  • Submission does not increase alerts or messages from prospector / lint

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@ronanstokes-db ronanstokes-db self-assigned this Mar 28, 2024
@ronanstokes-db ronanstokes-db added enhancement New feature or request labels Jun 5, 2024
@ronanstokes-db ronanstokes-db modified the milestone: v0.4.0 Jun 5, 2024
@ronanstokes-db ronanstokes-db merged commit da1df6b into master Jun 7, 2024
5 checks passed
@ronanstokes-db ronanstokes-db deleted the feature_standard_datasets branch June 7, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants