Introduce birthstone and BirthstoneLister #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyi
reviewed
Mar 29, 2025
pkg/block/fetcher.go
Outdated
| @@ -356,6 +356,129 @@ func (f *ConcurrentLister) GetActiveAndPartialBlockIDs(ctx context.Context, ch c | |||
| return partialBlocks, nil | |||
| } | |||
|
|
|||
| // ShadowLister lists block IDs cheap and fast replying on shadow meta files. | |||
| type ShadowLister struct { | |||
There was a problem hiding this comment.
might enable this as a new strategy similar to recursive and concurrent
jnyi
reviewed
Mar 29, 2025
pkg/block/block.go
Outdated
| @@ -40,6 +40,8 @@ const ( | |||
|
|
|||
| // DebugMetas is a directory for debug meta files that happen in the past. Useful for debugging. | |||
| DebugMetas = "debug/metas" | |||
| // ShadowMetaDirname is the directory name for shadow meta files. | |||
| ShadowMetaDirname = "shadow-meta" | |||
There was a problem hiding this comment.
the other files are under 1 block folder, but my understanding is you have
/BLOCK_1/meta.json
/BLOCK_2/meta.json
/BLOCK_3/meta.json
/shadow-meta/ some meta?
yuchen-db
changed the title
yuchen-db
force-pushed
the
db_main
branch
3 times, most recently
from
ca8c010 to
28db9f6
Compare
yuchen-db
force-pushed
the
db_main
branch
5 times, most recently
from
64fbb3a to
5276dd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
private PR: https://github.com/databricks-eng/universe/pull/999928
Add birthstone to mark the completeness of a block upload to cloud bucket. So the bucket looks like
This could help with metaSync which happens every minute.
Comparing number of API calls of different listers during syncMeta
item_per_page is a constant given by cloud provider, it defines the maximum number of items returned from a single LIST, usually 5000
If we have 5000 blocks and 10 files per block (chunks, meta, index), the three numbers will be