Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Use gofumpt instead of gofmt #4448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Internal] Use gofumpt instead of gofmt #4448

wants to merge 1 commit into from

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Jan 29, 2025

Changes

Gofumpt is a stricter version of gofmt. This is used in the cli repo, and we would like to adopt it in the TF provider as well.

In a follow-up PR, we will add golangci-lint using similar rules to the CLI repo: https://github.com/databricks/cli/blob/main/.golangci.yaml

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@mgyucht mgyucht requested review from a team as code owners January 29, 2025 14:14
@mgyucht mgyucht requested review from parthban-db and removed request for a team January 29, 2025 14:14
@mgyucht mgyucht temporarily deployed to test-trigger-is January 29, 2025 14:14 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 29, 2025 14:15 — with GitHub Actions Inactive
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4448
  • Commit SHA: 6021530ab15391ee82803b62af66b3cb52318d62

Checks will be approved automatically on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant