-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented to_list to Index/MultiIndex #1948
Conversation
FYI: This implementation idea is basically inspired from koalas/databricks/koalas/series.py Lines 1497 to 1515 in 138c7b8
|
Codecov Report
@@ Coverage Diff @@
## master #1948 +/- ##
==========================================
- Coverage 94.50% 91.19% -3.31%
==========================================
Files 45 49 +4
Lines 10682 10712 +30
==========================================
- Hits 10095 9769 -326
- Misses 587 943 +356
Continue to review full report at Codecov.
|
@@ -102,6 +102,7 @@ Conversion | |||
|
|||
Index.astype | |||
Index.item | |||
Index.to_list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we exclude "tolist" on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because pandas also exclude tolist
in their docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks!
I'll merge this for now. Let's address #1948 (comment) |
ref #1929 |
Added
to_list
-tolist
as an alias - to the Index and MultiIndex.This implementation idea is basically inspired from
Series.to_list
.