Skip redundant server call in setAutoCommit when value unchanged #1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize setAutoCommit to avoid unnecessary server round-trips when the requested autoCommit value matches the cached session value. This optimization only applies when FetchAutoCommitFromServer is disabled (the default), ensuring we still respect server state when that mode is enabled.
vikrantpuppala
approved these changes
Jan 5, 2026
gopalldb
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NO_CHANGELOG=true
Optimize setAutoCommit to avoid unnecessary server round-trips when the requested autoCommit value matches the cached session value. This optimization only applies when FetchAutoCommitFromServer is disabled (the default), ensuring we still respect server state when that mode is enabled.
Testing
Unit tests
Additional Notes to the Reviewer