-
Notifications
You must be signed in to change notification settings - Fork 108
Fixed bundle run for apps when compute is already starting #3478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes nightly tests
Could you specify which ones?
Also, can we add an acceptance tests that covers this?
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewnester This still seems relevant. Is that right?
@pietern yes, it is still relevant |
Changes
It can happen that after creating app the compute state returned from API is Starting already. Previously we incorrectly handled this and did not wait for the app to start first
Why
Fixes nightly tests
Tests