Add runner for DBR tests #3453
Draft
Add runner for DBR tests #3453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
commented
Aug 21, 2025
acceptance/acceptance_test.go
Outdated
| @@ -45,6 +46,7 @@ var ( | |||
| LogRequests bool | |||
| LogConfig bool | |||
| SkipLocal bool | |||
| Dbr bool | |||
There was a problem hiding this comment.
We could implicitly also rely on the DATABRICKS_RUNTIME_VERSION environment variable being set. But this feels more robust.
Either approach is good enough, though IMO.
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Aug 25, 2025
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
commented
Aug 25, 2025
| deadline, ok := t.Deadline() | ||
| if ok { | ||
| // If -timeout is configured for the test, wait until that time for the job run results. | ||
| run, err = waiter.GetWithTimeout(time.Until(deadline)) |
There was a problem hiding this comment.
The intention here really is to increase the timeout since the default one is too short. I suspect eventually we might need a custom poller here since even with a bigger timeout this method often fails due to some opaque TCP error.
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This was referenced Aug 27, 2025
shreyas-goenka
added a commit
that referenced
this pull request
Aug 27, 2025
## Changes The—workspace-tmp-dir option makes the acceptance testing framework run the test using the workspace file system instead of the local file mount. ## Why This option is necessary to simulate DABs in the workspace, since it runs the Databricks CLI on the workspace file system. ## Tests Manually. I've been using this function to run a couple of test runs in my other PR: #3453
shreyas-goenka
added a commit
that referenced
this pull request
Aug 27, 2025
## Why Feedback in #3453 (comment) recommended not using build tags. This PR enables these tests by default. These tests will be skipped when `-short` flag is provided. Note: We do not specify the `-short` flag in CI so these tests will run by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a test runner that can run integration tests on DBR. A follow-up PR will use it to run integration tests on nightly jobs and PRs.
Why
Running integration tests on DBR is important for DABs in the workspace.
Tests
Manually running the test. All integration tests run and pass, except the ones that are broken on main right now, like
TestAccept/bundle/run/app-with-job