Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion array_api_compat/common/_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,7 @@ def array_namespace(

use_compat: bool or None
If None (the default), the native namespace will be returned if it is
already array API compatible, otherwise a compat wrapper is used. If
already array API compatible; otherwise, a compat wrapper is used. If
True, the compat library wrapped library will be returned. If False,
the native library namespace is returned.

Expand Down
2 changes: 1 addition & 1 deletion array_api_compat/dask/array/linalg.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def qr( # type: ignore[no-redef]
# and dask doesn't have the full_matrices keyword
def svd(x: Array, full_matrices: bool = True, **kwargs: object) -> SVDResult: # type: ignore[no-redef]
if full_matrices:
raise ValueError("full_matrics=True is not supported by dask.")
raise ValueError("full_matrices=True is not supported by dask.")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the most important change in the PR (and kinda the reason I meant to make the PR) -- I'm sorry I missed including it initially.

return da.linalg.svd(x, coerce_signs=False, **kwargs)

def svdvals(x: Array) -> Array:
Expand Down
4 changes: 2 additions & 2 deletions docs/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ Thomas Li
`xp.__array_namespace_info__()`.
- Various fixes to the `clip()` wrappers.

- `torch.conj` now wrapps `torch.conj_physical`, which makes a copy rather
- `torch.conj` now wraps `torch.conj_physical`, which makes a copy rather
than setting the conjugation bit, as arrays with the conjugation bit set do
not support some APIs.

Expand Down Expand Up @@ -298,7 +298,7 @@ Thomas Li

- New flag `use_compat` to {func}`~.array_namespace` to force the use or
non-use of the compat wrapper namespace. The default is to return a compat
namespace when it is appropiate.
namespace when it is appropriate.

- Fix the `copy` flag to `asarray` for NumPy, CuPy, and Dask.

Expand Down
2 changes: 1 addition & 1 deletion docs/dev/releasing.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

This does mean you can ignore CI failures, but ideally you should fix any
failures or update the `*-xfails.txt` files before tagging, so that CI and
the CuPy tests fully pass. Otherwise it will be hard to tell what things are
the CuPy tests fully pass. Otherwise, it will be hard to tell what things are
breaking in the future. It's also a good idea to remove any xpasses from
those files (but be aware that some xfails are from flaky failures, so
unless you know the underlying issue has been fixed, an xpass test is
Expand Down
Loading