Fixed axis labels being cut off in interactive histograms #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-luka
changed the title
|
Hi @k-luka - thanks for this. Unfortunately, here are a lot of formatting changes (which I'd highly prefer not to have, to be honest), so it's hard to review what changes exactly you've made. Additionally, I need a screenshot proof of your testing of this (and ideally, a change in the test notebook for plots that show this case). Given both of these, it will take a longer time than I'd like to spend to review this - so I'd like to see both of these fixed before I can dedicate time to review. |
davidwagner
reviewed
Nov 17, 2024
| # Matplotlib has deprecated the normed keyword. | ||
| # TODO consider changing this function to use density= instead too |
There was a problem hiding this comment.
What is the justification for removing this TODO?
davidwagner
reviewed
Nov 17, 2024
| type(self).plots.append(axis) | ||
|
|
||
| # Added to ensure proaper axis label dimensions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Axis labels were being cut off in histograms when using
%matplotlib notebook. This affected the readability of the plots.Fix:
Added
plt.tight_layout()to thedraw_histfunction intables.pyto ensure the layout is automatically adjusted to prevent labels from being cut off.Testing:
Tested the
histmethod using both%matplotlib notebookand%matplotlib inlinebackends to confirm that the issue is resolved without introducing any side effects.Related Issues:
Make Plots Compatible with %matplotlib notebook #538