fix: refuse to create new clsig if we switched to a different fork while we were signing #6502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
force-pushed
the
no_clsig_tip_changes
branch
from
d141f1f to
9b6e7c2
Compare
UdjinM6
changed the title
…ile we were signing
UdjinM6
force-pushed
the
no_clsig_tip_changes
branch
from
9b6e7c2 to
0fc0bec
Compare
knst
reviewed
Dec 23, 2024
| return {}; | ||
| } | ||
|
|
||
| const auto pindex = m_chainstate.m_chain.Tip()->GetAncestor(lastSignedHeight); |
Collaborator
There was a problem hiding this comment.
if we will have a new chainlock we need to switch chain here to the new one, because it is a new chain-locked tip and current tip should be refused, isn't it true?
Collaborator
|
@UdjinM6 no longer targeted for 22.1? |
|
This pull request has conflicts, please rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Signing is async so it's possible that our clsig is no longer relevant
What was done?
How Has This Been Tested?
Breaking Changes
Checklist: