CI housekeeping #104
Merged
CI housekeeping #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianmeng
commented
Aug 5, 2024
mix.exs
Outdated
| @@ -9,7 +9,7 @@ defmodule BroadwayCloudPubSub.MixProject do | |||
| [ | |||
| app: :broadway_cloud_pub_sub, | |||
| version: @version, | |||
| elixir: "~> 1.11", | |||
| elixir: "~> 1.12", | |||
There was a problem hiding this comment.
Bump to 1.12 where the security support just ended recently, see https://endoflife.date/elixir
Not sure if we should sync with Broadway min Elixir requirement, which is still set to 1.7, see https://github.com/dashbitco/broadway/blob/9eaf2140b6c1f36b25f990a7c74052bece26aadc/mix.exs#L11
There was a problem hiding this comment.
It is end of life but we should not be the ones forcing users to update. If we can still support 1.11, then it should. :)
There was a problem hiding this comment.
Noted, and updated.
kianmeng
force-pushed
the
ci-housekeeping
branch
from
fd6112a
to
1b2f998
Compare
List of changes: - add Elixir 1.17 / Erlang OTP 27 to CI - bump github actions
kianmeng
force-pushed
the
ci-housekeeping
branch
from
1b2f998
to
d0784c2
Compare
|
💚 💙 💜 💛 ❤️ |
|
🥳 🥳 🥳 🥳 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes: