Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server side env var interpolation #285

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

roshan-gh
Copy link
Contributor

This pull request enhances server-side validation by introducing support for environment variable interpolation. It extends the existing configuration resolver logic to recognize and interpolate environment variables specified in the configuration. The changes ensure that environment variables can be seamlessly incorporated into the validation process, enhancing the flexibility and accuracy of server-side validation.

@roshan-gh roshan-gh requested a review from bripkens January 16, 2024 01:51
@roshan-gh roshan-gh self-assigned this Jan 16, 2024
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
otelbin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 1:48pm

Copy link

socket-security bot commented Jan 16, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@radix-ui/[email protected] Transitive: environment +15 6.95 MB benoitgrelard

View full report↗︎

Copy link
Member

@mmanciop mmanciop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more hardened var detection was already specc'd in the #156 issue

@@ -250,3 +252,32 @@ export function selectConfigType(config: string) {
return config;
}
}

export function extractVariables(inputString: string): string[] {
const variableRegex = /\${([^}]+)}/g;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec of the env var detection is here: #156

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

6 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants