feat: various social image improvements #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bripkens
force-pushed
the
social-image-improvements
branch
from
9ed1fe6 to
63efa31
Compare
bripkens
force-pushed
the
social-image-improvements
branch
from
63efa31 to
9298900
Compare
bripkens
force-pushed
the
social-image-improvements
branch
from
9298900 to
c7cc550
Compare
bripkens
force-pushed
the
social-image-improvements
branch
from
c7cc550 to
a14efbb
Compare
bripkens
force-pushed
the
social-image-improvements
branch
from
a14efbb to
52e69e2
Compare
bripkens
force-pushed
the
social-image-improvements
branch
from
52e69e2 to
a63d9c3
Compare
bripkens
force-pushed
the
social-image-improvements
branch
from
a63d9c3 to
db2b453
Compare
bripkens
force-pushed
the
social-image-improvements
branch
from
db2b453 to
3b0c758
Compare
bripkens
commented
Dec 20, 2023
| @@ -66,7 +66,7 @@ const Node = ({ data, icon, type }: { data: IData; icon: React.ReactNode; type: | |||
| <div style={customNodeStyles} tw="flex-col"> | |||
| <div | |||
| tw={`flex w-full flex-col items-center justify-center px-2 ${ | |||
| splitLabel[1] && splitLabel[1].length > 0 && "mt-[2px]" | |||
| splitLabel[1] && splitLabel[1].length > 0 ? "mt-[2px]" : "" | |||
There was a problem hiding this comment.
This caused warnings in the logic because of an unknown tailwind utility called undefined
bripkens
commented
Dec 20, 2023
| const shortLink = await redis.get<string>(getShortLinkPersistenceKey(params.id)); | ||
| return NextResponse.redirect(shortLink || "/", { | ||
| headers: { | ||
| "Cache-Control": "public, max-age=3600, stale-while-revalidate=3600, stale-if-error=3600", |
There was a problem hiding this comment.
This can actually cause issues without the correct Vary response header. Hence caching is removed for this code path.
bripkens
commented
Dec 20, 2023
| @@ -55,13 +54,14 @@ export async function POST(request: NextRequest): Promise<NextResponse> { | |||
| ); | |||
| } | |||
|
|
|||
| const uuid = crypto.randomUUID(); | |||
| await redis.set(getShortLinkPersistenceKey(uuid), longURL); | |||
| const id = crypto.createHash("sha1").update(longURL).digest("hex"); | |||
There was a problem hiding this comment.
This ensures that there are fewer short link permutations for the same data.
# Why - There are some things I noticed after the review that we should clean up. - The ability to generate the image server-side is incredible. Folks can actually use this to link to the image from within documentation systems! # What - Expose the feature more prominently in the share dialog - Clean up the URL paths to make this easier to discover - Some cleanup
bripkens
force-pushed
the
social-image-improvements
branch
from
3b0c758 to
92c80c0
Compare
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What
Screenshots