fix: select text in validation console #186
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…or-validation-console-texts
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
@bripkens selecting text in validation console fixed
| @@ -22,7 +22,6 @@ export function ResizeBar({ onWidthChange }: ResizeBarProps) { | |||
| }; | |||
|
|
|||
| const onMouseMove = (e: MouseEvent) => { | |||
| e.preventDefault(); | |||
There was a problem hiding this comment.
suggestion: I believe we should still call e.preventDefault() when state.current.dragging. This ensures that text selection doesn't happen when resizing the editor.
There was a problem hiding this comment.
Previously we didn't have the Autosizer component, and selecting other texts problem was happening, with the current Autosizer, I tested ResizeBar without e.preventDefault(); there is no problem with selecting other texts. @bripkens
There was a problem hiding this comment.
yep, seems to only occur in the error panel. Which is okay.
There was a problem hiding this comment.
@bripkens hmm it's strange, I tested in Chrome, and there was no extra selecting text in anywhere.
No description provided.