feat: validate the configuration against actual collector binaries running on AWS #111
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bripkens
changed the title
|
@mmanciop is attempting to deploy a commit to the OTelBin Team on Vercel. To accomplish this, @mmanciop needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
mmanciop
force-pushed
the
backend-validation
branch
from
47bd260 to
ba687e5
Compare
|
|
||
| 1. Visualize for you the configured OpenTelemetry Collector pipelines as swimlanes | ||
| 1. Validate your configuration and highlight errors | ||
| 1. Enable you to share your OpenTelemetry Collector configurations online (requires login with a GitHub or Google account) |
There was a problem hiding this comment.
Issue: This is not the case. Only short-linking requires a sign in.
| "lucide-react": "^0.284.0", | ||
| "monaco-editor": "^0.43.0", | ||
| "monaco-languageserver-types": "^0.2.3", | ||
| "monaco-yaml": "^5.1.0", | ||
| "next": "^13.5.4", | ||
| "projen": "^0.73.37", |
There was a problem hiding this comment.
Question: Why is this a dependency of OTelBin?
| OTelBin is a configuration tool for [OpenTelemetry collector pipelines](https://opentelemetry.io/docs/collector). | ||
| OTelBin is a configuration tool to help you get the most out of the [OpenTelemetry Collector](https://opentelemetry.io/docs/collector/). | ||
|
|
||
|  |
There was a problem hiding this comment.
Issue: Let's remove this until we have the nice angled image of OTelBin. It is on my todo list to do this once we have the final logo.
There was a problem hiding this comment.
Issue: This image has nothing to do with the deployed OTelBin app. We should it remove it from here. I'd suggest we upload it to GitHub directly instead of maintaining it within the repository.
validation-src/.eslintrc.json
Outdated
There was a problem hiding this comment.
Suggestion: Move validation-src to packages/validation-src to align with common monorepo structures.
There was a problem hiding this comment.
Once this is merged, we should imho move otelbin then also to packages/otelbin
|
|
||
| * Collaborate with other contributors and maintainers during the PR review process. Address any feedback or comments to ensure the schema aligns with the project's needs. | ||
| 7. __Create a Pull Request:__ | ||
| * Visit your forked repository on GitHub and create a pull request (PR) to merge your changes into the main repository's JSON schema. |
There was a problem hiding this comment.
Suggestion: Add a section to CONTRIBUTING.md explaining what packages/validation-src is and how to work on it.
mmanciop
force-pushed
the
backend-validation
branch
from
71c641d to
f730efc
Compare
…idates which distro version
mmanciop
changed the title
No description provided.