Skip to content

Commit

Permalink
fix: script permissions and wiring in pipelines
Browse files Browse the repository at this point in the history
  • Loading branch information
mmanciop committed Nov 7, 2023
1 parent 9f52df3 commit bcf8b79
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:
# is available only for pull trigger. Otherwise, use the branch on which the commit was pushed.
# (Ref names in pull requests are in the shape of `<pr_id>/merge` and those will break CDK.)
run: |
./.github/workflows/scripts/test_env_name.sh >> $GITHUB_OUTPUT || exit 1
echo "test_env_name=$(./.github/workflows/scripts/test_env_name.sh)" >> $GITHUB_OUTPUT || exit 1
- name: Deploy validation backend
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/clean-up-test-env.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
# is available only for pull trigger. Otherwise, use the branch on which the commit was pushed.
# (Ref names in pull requests are in the shape of `<pr_id>/merge` and those will break CDK.)
run: |
./.github/workflows/scripts/test_env_name.sh >> $GITHUB_OUTPUT || exit 1
echo "test_env_name=$(./.github/workflows/scripts/test_env_name.sh)" >> $GITHUB_OUTPUT || exit 1
- name: Delete validation backend
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scripts/test_env_name.sh
100644 → 100755
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/env bash
#!/usr/bin/env bash

# Ensure test name is not long enough to break restrictions on length names in AWS (e.g., role-name length)
# This logic ensures test envs have max length 18. Names of length 13 to 17 will become of length 18 to ensure
Expand Down

0 comments on commit bcf8b79

Please sign in to comment.