Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes in Matrix, Array, GlobRef #417

Merged
merged 7 commits into from
Jul 3, 2017
Merged

Fixes in Matrix, Array, GlobRef #417

merged 7 commits into from
Jul 3, 2017

Conversation

devreal
Copy link
Member

@devreal devreal commented Jun 27, 2017

This PR fixes some issues I came across recently, some of which are documented in #412.

  • Fix postfix increment/decrement operators in GlobRef to return the value type and keep postfix semantics
  • Add test case for GlobRef arithmetic operations
  • Make publicly exposed types in Matrix and Array public
  • Fix operator<< on GlobViewIter
  • Add a variadic version of allocate() to Matrix and Array to provide a similar interface as the constructors.

@devreal devreal added this to the dash-0.3.0 milestone Jun 27, 2017
@devreal devreal self-assigned this Jun 27, 2017
@devreal devreal requested review from fuchsto and fmoessbauer June 27, 2017 11:45
@devreal devreal mentioned this pull request Jun 27, 2017
Closed
@devreal devreal merged commit 4898545 into development Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoessbauer fmoessbauer fmoessbauer approved these changes

@fuchsto fuchsto Awaiting requested review from fuchsto

Assignees

@devreal devreal

Labels
enhancement
Projects
None yet
Milestone
dash-0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@devreal @fmoessbauer