Cleanup in dash::CSRPattern and dash::Array #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuchsto
requested review from
rkowalewski,
fmoessbauer,
devreal and
BenjaProg
This was referenced Feb 13, 2017
BenjaProg
approved these changes
Feb 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using default definitions for copy- and assignment apparently fixed the defect reported in #256
Also, performance of
CSRPattern<1>significantly improved according to benchmarkbench.05.pattern. GUPS ofirreg(CSRPattern) changed from ~0.5 to ~1.0 with raw pointer access (maximum achievable GUPS) at ~2.3Update: The test still segfaults in Release build with OpenMPI.
The actual defect is in allocation in DART, see #280 and
CSRPatternTestin #279