ci: Add concurrency cancel-in-progress to remaining workflows #2456
Conversation
Add concurrency configuration to cancel in-progress CI jobs when new commits are pushed to the same branch, with exceptions for: - main branch (never cancel to ensure full test coverage) - scheduled jobs (never cancel to ensure periodic validation runs) Changes: - ci_altlinux.yml: Add concurrency block (was missing) - ci_freebsd.yml: Add concurrency block (was missing) - update_lockfiles.yml: Change cancel-in-progress from 'true' to conditional expression to exclude scheduled runs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62a733cc70
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Move concurrency from workflow-level to job-level with matrix.base in the group. This prevents race conditions when overlapping runs push to the same update-pixi-* branches while still allowing jobs for different base branches to run in parallel. Addresses review feedback about potential non-fast-forward push failures.
|
Addressed in 363eea0 - moved concurrency to job-level with |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Document that AI agents should not reply to AI-generated review comments (e.g., Codex bot). The code change is the response - no need for bot-to-bot conversations that clutter PR history.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bda4c6b2fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Include github.event_name in the concurrency group key so that manual workflow_dispatch runs don't cancel in-progress scheduled runs. This ensures weekly lockfile updates complete even if someone triggers a manual run during the scheduled window.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9bfd1365b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This workflow has no push trigger, so the 'cancel on new commit' behavior doesn't apply. Using cancel-in-progress: false ensures runs queue instead of racing or cancelling each other, preventing push conflicts on the update-pixi-* branches.
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Document the GitHub GraphQL API for resolving review threads, enabling AI agents to mark conversations as resolved after addressing feedback without adding noisy comments.
Document the complete workflow for AI agents handling automated reviews: 1. Push fix 2. Re-trigger review (@codex review) 3. Monitor for new issues or 'no issues' response 4. Resolve threads and finish when clean
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
ci_altlinux.ymlandci_freebsd.yml(were missing)update_lockfiles.ymlto not cancel scheduled jobs (was usingcancel-in-progress: true)Details
This ensures all CI workflows cancel in-progress jobs when new commits are pushed to the same branch, except:
All workflows now use the consistent pattern:
Checklist