Fix: Validate external forces to prevent NaN/Inf crash (DART 6.16) #2443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BodyNode::addExtForce,setExtForce,addExtTorque,setExtTorquePointMass::addExtForceRelated Issue
Addresses gz-physics#844 - Crash in
BodyNode::updateBiasForcewhen Gazebo Hydrodynamics plugin passes NaN parameters (e.g.,<xDotU>NaN</xDotU>).Changes
dart/dynamics/BodyNode.cppdart/dynamics/PointMass.cpptests/unit/dynamics/test_BodyNodeExternalForce.cpptests/unit/dynamics/CMakeLists.txttests/unit/CMakeLists.txtTesting
All 9 new unit tests pass locally:
AddExtForceWithNaNAddExtForceWithInfAddExtForceWithNaNOffsetSetExtForceWithNaNAddExtTorqueWithNaNAddExtTorqueWithInfSetExtTorqueWithNaNValidForceApplicationGzPhysics844Scenario