forked from RunestoneInteractive/fopp
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOz #8
Open
mert-ozkan
wants to merge
20
commits into
dartmouth-pbs:pbs-psyc161-wi19
Choose a base branch
from
mert-ozkan:MOz
base: pbs-psyc161-wi19
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
MOz #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates, mostly to advanced accumulation chapter
The final problem in the section uses this terminology, but the initial definition was inconsistent.
The nth character is the character at index n+1
Exercise said compiler/interpreter
runtime error not found by compiler
instance method limbs not class method for Animal class
[ENH] Add missing feedback to MC question in section Iterables
[FIX]: make activecode section 8, 4.4.4, actual active code
yarikoptic
reviewed
Jan 24, 2019
@@ -95,7 +95,7 @@ Chapter Assessment | |||
:autograde: unittest | |||
:practice: T | |||
|
|||
Write code that counts the number of words in ``sentence`` that contain *either* an "a" or an "e". Store the result in the variable ``num_a_or_e``. | |||
Write code that counts the number of words in ``sentence`` that contains at least one of the letters "a" and "e". Store the result in the variable ``num_a_or_e``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this change makes it clearer, so probably not worth submitting upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.