New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use brighness for links, opacity for monochrome icons. #8528

Merged

isoos merged 1 commit into dart-lang:master from isoos:brightness

Feb 6, 2025

Collaborator

isoos commented Feb 5, 2025

Opacity change on hover may not be a good idea #8493
Setting the filter: brightness(...%) is much better for our links, as their color is now pushed towards stronger contrast.
However, it does not work with the monochrome icons, introducing a new class for it and using it on the version's tab icons.

Hovering on the versions tab icons before:

Hovering on the versions tab icons after:

Note: the difference is that the current behavior reduced the contrast, while the new one increases it. It can also be tested on staging now.


          Use brighness for links, opacity for monochrome icons.

f894ed2

isoos requested review from jonasfj and sigurdm

February 5, 2025 15:58

Collaborator Author

isoos commented Feb 5, 2025

jonasfj approved these changes

View reviewed changes

isoos merged commit 4c262e1 into dart-lang:master

32 checks passed

isoos deleted the brightness branch

February 6, 2025 10:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet