Detect incompatible local Chrome versions when running puppeteer. #8512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Jan 31, 2025
| if (mainVersion == null) continue; | ||
| // Main version is after the currently supported version, will fail. | ||
| // https://github.com/xvrh/puppeteer-dart/issues/364 | ||
| if (mainVersion >= 132) continue; |
There was a problem hiding this comment.
Won't we all soon only have versions after this?
There was a problem hiding this comment.
Maybe, I don't really know. We probably will, when we upgrade the puppeteer version next time.
sigurdm
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there is some known incompatibility with new chrome versions and the puppeteer package. Updating the code to check for version when attempting to run local chrome instance, and also removing the extra check from the CI environment (in case it upgraded the chrome version).
See xvrh/puppeteer-dart#364