Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix if condition to prevent NPE on cache race situations. #8506

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Fix if condition to prevent NPE on cache race situations. #8506

merged 1 commit into from
Jan 30, 2025

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jan 29, 2025

Fixes #8502

Otherwise the list of versions may be behind the current value, leaving the possibility of NPE.

@isoos isoos requested review from jonasfj and sigurdm January 29, 2025 15:41
@isoos isoos merged commit 1ccd4d5 into dart-lang:master Jan 30, 2025
31 checks passed
@isoos isoos deleted the fix-8502 branch January 30, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null check error in package versions page rendering
2 participants
@isoos @sigurdm