Timeouts and VM exit for index building process. #8504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
reviewed
Jan 29, 2025
| stderr.writeln('Timeout triggering VM termination\n$trace'); | ||
| _logger.pubNoticeShout( | ||
| 'vm-termination', | ||
| 'Timeout triggering VM termination', |
There was a problem hiding this comment.
Does this terminate the VM or does AppEngine just restart the process?
| await for (final package in dbService.query<Package>().run()) { | ||
| if (package.isNotVisible) { | ||
| continue; | ||
| await withVmTerminationTimeout(timeout: Duration(hours: 12), () async { |
There was a problem hiding this comment.
Why not just add .timeout(Duration(hours: 12)) when calling doCreateAndUpdateSnapshot?
If such a timeout does happen there, isn't that a good place to just not catch the timeout and let it bubble all the way up? Do we need to explicitly kill the VM?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exitto make sure the VM is restarted.