Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased contrast in the detail tab selected text color. #8492

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Increased contrast in the detail tab selected text color. #8492

merged 1 commit into from
Jan 24, 2025

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jan 24, 2025

  • Issue reported by Lighthouse.
  • Instead of using a blended color in dark mode, now using the link color in both light and dark mode.

Before/after:
image
image

@isoos isoos requested review from jonasfj and sigurdm January 24, 2025 11:15
@isoos
Copy link
Collaborator Author

isoos commented Jan 24, 2025

/cc @parlough

@isoos isoos merged commit a424956 into dart-lang:master Jan 24, 2025
31 checks passed
@isoos isoos deleted the detail-tab branch January 24, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isoos @sigurdm