Add topics-tag class on infobox topic links. (#8497)

dart-lang · Jan 27, 2025 · 74d9811 · 74d9811
1 parent f15ec13
commit 74d9811
Show file tree

Hide file tree

Showing 31 changed files with 62 additions and 61 deletions.
diff --git a/app/lib/frontend/templates/views/pkg/info_box.dart b/app/lib/frontend/templates/views/pkg/info_box.dart
@@ -54,7 +54,7 @@ d.Node packageInfoBoxNode({
     );
   }
   final dependencies = _dependencyListNode(version.pubspec?.dependencies);
-  final topics = _topicstNode(version.pubspec?.canonicalizedTopics);
+  final topics = _topicsNode(version.pubspec?.canonicalizedTopics);
 
   final screenshots = data.scoreCard.panaReport?.screenshots;
   String? thumbnailUrl;
@@ -206,7 +206,7 @@ d.Node? _licenseNode({
   ]);
 }
 
-d.Node? _topicstNode(List<String>? topics) {
+d.Node? _topicsNode(List<String>? topics) {
   if (topics == null || topics.isEmpty) return null;
 
   final nodes = <d.Node>[];
@@ -217,6 +217,7 @@ d.Node? _topicstNode(List<String>? topics) {
     final ct = canonicalTopics.asMap[topic];
     final description = ct?.description;
     final node = d.a(
+      classes: ['topics-tag'],
       href: urls.searchUrl(q: 'topic:$topic'),
       text: '#$topic',
       title: description,

diff --git a/app/test/frontend/golden/pkg_activity_log_page.html b/app/test/frontend/golden/pkg_activity_log_page.html
@@ -396,7 +396,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -472,7 +472,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/frontend/golden/pkg_admin_page.html b/app/test/frontend/golden/pkg_admin_page.html
@@ -681,7 +681,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -757,7 +757,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/frontend/golden/pkg_changelog_page.html b/app/test/frontend/golden/pkg_changelog_page.html
@@ -266,7 +266,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -343,7 +343,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/frontend/golden/pkg_example_page.html b/app/test/frontend/golden/pkg_example_page.html
@@ -263,7 +263,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -340,7 +340,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/frontend/golden/pkg_install_page.html b/app/test/frontend/golden/pkg_install_page.html
@@ -289,7 +289,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -366,7 +366,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/frontend/golden/pkg_score_page.html b/app/test/frontend/golden/pkg_score_page.html
@@ -351,7 +351,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -428,7 +428,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html b/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html
@@ -351,7 +351,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -428,7 +428,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/frontend/golden/pkg_show_page.html b/app/test/frontend/golden/pkg_show_page.html
@@ -266,7 +266,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -343,7 +343,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/frontend/golden/pkg_show_page_discontinued.html b/app/test/frontend/golden/pkg_show_page_discontinued.html
@@ -257,7 +257,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -332,7 +332,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/frontend/golden/pkg_show_page_flutter_plugin.html b/app/test/frontend/golden/pkg_show_page_flutter_plugin.html
@@ -255,7 +255,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -336,7 +336,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/frontend/golden/pkg_show_page_publisher.html b/app/test/frontend/golden/pkg_show_page_publisher.html
@@ -257,7 +257,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -329,7 +329,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/frontend/golden/pkg_show_page_retracted.html b/app/test/frontend/golden/pkg_show_page_retracted.html
@@ -242,7 +242,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Funding</h3>
             <p>
@@ -314,7 +314,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Funding</h3>
           <p>

diff --git a/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html b/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html
@@ -248,7 +248,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -323,7 +323,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/frontend/golden/pkg_show_version_page.html b/app/test/frontend/golden/pkg_show_version_page.html
@@ -260,7 +260,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -337,7 +337,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/frontend/golden/pkg_versions_page.html b/app/test/frontend/golden/pkg_versions_page.html
@@ -373,7 +373,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -450,7 +450,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/task/testdata/goldens/packages/oxygen.html b/app/test/task/testdata/goldens/packages/oxygen.html
@@ -254,7 +254,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -333,7 +333,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/task/testdata/goldens/packages/oxygen/changelog.html b/app/test/task/testdata/goldens/packages/oxygen/changelog.html
@@ -260,7 +260,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -339,7 +339,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/task/testdata/goldens/packages/oxygen/example.html b/app/test/task/testdata/goldens/packages/oxygen/example.html
@@ -255,7 +255,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -334,7 +334,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/task/testdata/goldens/packages/oxygen/install.html b/app/test/task/testdata/goldens/packages/oxygen/install.html
@@ -283,7 +283,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -362,7 +362,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>

diff --git a/app/test/task/testdata/goldens/packages/oxygen/license.html b/app/test/task/testdata/goldens/packages/oxygen/license.html
@@ -256,7 +256,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
             </p>
             <h3 class="title">Topics</h3>
             <p>
-              <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+              <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
             </p>
             <h3 class="title">Documentation</h3>
             <p>
@@ -335,7 +335,7 @@ <h3 class="title pkg-infobox-metadata">Metadata</h3>
           </p>
           <h3 class="title">Topics</h3>
           <p>
-            <a href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
+            <a class="topics-tag" href="/packages?q=topic%3Achemical-element" rel="nofollow">#chemical-element</a>
           </p>
           <h3 class="title">Documentation</h3>
           <p>