Fix relative imports in wasm loader #3752
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the loader script emitted by
build_web_compilersresolves URLs against the base-URL of the active document. This breaks when the entrypoint script is not in the same directory as the page, e.g. inTo fix this, this PR changes the logic to resolve URLs against the loader script (which would be
/src/app.dart.jsin the example, properly resolving the other dart2wasm/dart2js components).I've also added an integration test using a
<script>tag pointing to a subdirectory to make sure that this is working now.Closes #3751