Prepare translatable strings #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
translation facilities. Changed translatable messages with arguments to use string.format for one complete string versus snippets. Removed gen_i18n_mo since we will be using darktable's translation facilities and there's no need to generate lua specific mo files.
TurboGit
reviewed
Feb 5, 2024
contrib/LabelsToTags.lua
Outdated
| ["*****4"] = { "Four stars", "Not rejected" }, | ||
| ["*****5"] = { "Five stars", "Not rejected" }, | ||
| ["*****R"] = { "Rejected" } } | ||
| [_("Colors")] = { ["+*****"] = { _("Red") }, |
There was a problem hiding this comment.
Just a quick look, I think all strings should be lower-case.
- Ensure that identical string on dt side will be used to translation
- Ensure consistent UI for standard dt
- The English capitalized UI is now handled as a separate translation and maintained by @victoryforce.
There is many strings like this on this PR.
There was a problem hiding this comment.
I lower cased all strings except for things such as status (ERROR/SUCCESS), file types (HTML, KML, KMZ), script names, darktable variables in strings (i.e. $(FILE_NAME))
handle the translations yet. In 5.0 this will be removed
and darktable will handle translating the strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare the lua scripts for inclusion in the darktable translation workflow.
Partially fixes #451