Skip to content

Conversation

@siri-varma
Copy link
Contributor

@siri-varma siri-varma commented Dec 1, 2025

Description

Implements the Cryptography Alpha1 API (EncryptAlpha1/DecryptAlpha1) for the Dapr Java SDK, enabling streaming encryption and decryption operations using Dapr's cryptography building block.

Changes

  • Added EncryptRequestAlpha1 and DecryptRequestAlpha1 domain objects with fluent setters
  • Added encrypt() and decrypt() methods to DaprPreviewClient interface
  • Implemented streaming gRPC bidirectional communication in DaprClientImpl
  • Added unit tests for domain objects
  • Added integration tests using Testcontainers with local storage crypto component

Issue reference

Closes #1073

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@siri-varma siri-varma force-pushed the users/svegiraju/add-cryptography branch from ed91b07 to 213240d Compare December 1, 2025 22:31
@siri-varma siri-varma changed the title Users/svegiraju/add cryptography Add Cryptography APIs to the Java SDK Dec 2, 2025
@siri-varma siri-varma marked this pull request as ready for review December 2, 2025 06:22
@siri-varma siri-varma requested review from a team as code owners December 2, 2025 06:22
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit history seems to have a lot of extra things in it. Can you confirm you branched from master originally and remove the extra commits showing in the history? Also, CI seems a bit red - mind taking a look?

Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
@siri-varma siri-varma force-pushed the users/svegiraju/add-cryptography branch 2 times, most recently from 2d296ed to e719567 Compare December 14, 2025 23:06
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 85.10638% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.82%. Comparing base (d759c53) to head (04bc78a).
⚠️ Report is 242 commits behind head on master.

Files with missing lines Patch % Lines
...k/src/main/java/io/dapr/client/DaprClientImpl.java 81.41% 14 Missing and 7 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1599      +/-   ##
============================================
+ Coverage     76.91%   78.82%   +1.90%     
- Complexity     1592     1996     +404     
============================================
  Files           145      219      +74     
  Lines          4843     6111    +1268     
  Branches        562      676     +114     
============================================
+ Hits           3725     4817    +1092     
- Misses          821      946     +125     
- Partials        297      348      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Cryptography API to Java SDK

2 participants