add orchestration processor idempotency test #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a new unit test that reproduces a bug I'm troubleshooting
the handling of execution started event is not idempotent and it doesn't guarantee that the orchestrator is actually executed when retried
my expectation is that when
ProcessWorkItemreturns an error, it is expected thatProcessWorkItemcan be retried in the future with the same WorkItem, then the source of problems is when the state passed inside of the WorkItem is the same as the state used for the firstProcessWorkIteminvocation. In that caseProcessWorkItemdoesn't have an idempotent behavior and in the second invocation doesn't callw.executor.ExecuteOrchestratorSo the sequence of events I would expect are:
NextWorkItemProcessWorkItem, it invokesexecutor.ExecuteOrchestratorbut it fails andProcessWorkItemreturns an errorNextWorkItemProcessWorkItem, it SHOULD invokeexecutor.ExecuteOrchestrator