-
Notifications
You must be signed in to change notification settings - Fork 544
Add a new name resolution method: structuredformat #4085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: seal90 <[email protected]>
…contrib into config-string
mikeee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me, could you please open up a docs PR?
Cheers!
|
Will do — I’ll open a docs PR . |
|
I've opened the docs PR — thanks for the review! |
sicoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments so far. Can you also look at all the struct fields added and make them unexported by default where applicable please? Thank you for your contribution!! 🙌
Signed-off-by: seal90 <[email protected]>
…contrib into config-string
|
Hello! I've fixed and optimized both the code and the documentation. |
Description
Add a new name resolution method: structuredformat.
Service invocation can be configured with just a simple text-based configuration.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[4084]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.