-
Notifications
You must be signed in to change notification settings - Fork 544
Adds Global TTL Configuration for DynamoDB State Store #4055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Would be nice when the different statestores (Redis and Dynamo) behave in a similar way. |
|
There will be a slight delay in reviewing the DynamoDB-related PRs. We need to address the missing/disabled tests first, which are being tracked in issue #4047. Thanks for your patience! |
|
@sicoyle Ready for another review round |
sicoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last comment and then this LGTM - thank you!
Fixed. Also updated the docs PR with the same description |
b51bf00 to
e01dcdf
Compare
|
@ZeynelKoca pls see the build failures and ping when you're ready and I can retrigger 🙏 |
50d65a1 to
e01dcdf
Compare
|
@sicoyle Fixed a stupid rebase mistake. Try again? |
e8b1d9d to
8e8f446
Compare
8e8f446 to
494a6b9
Compare
|
@sicoyle Can the pipeline run get an approval? |
|
@sicoyle Fixed the formatting 🙏 |
|
@sicoyle I think a re-run is needed? Pipelines failed due to being unable to checkout the repo |
rerunning, lets see. I know github has been having quite a few issues recently |
Fixed another formatting issue 🙏 |
6b25c88 to
3eb43a9
Compare
3eb43a9 to
ced1c9e
Compare
|
@sicoyle Can you trigger a pipeline run? I see that the corresponding docs PR has already been merged. |
sicoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as long as the build passes, then LGTM. Thank you for your contribution and iterating on feedback 🤗
c4d17ec to
3713675
Compare
|
@sicoyle Thanks! The build failed again due to formatting issues (🙄) so I upgraded to the exact go version the pipeline was using. |
LOL I feel this 😄 It's running. Will circle back later today and if all green we can send it 🚀 |
34dfff9 to
67c7712
Compare
Signed-off-by: Zeynel Koca <[email protected]>
Signed-off-by: Zeynel Koca <[email protected]>
Signed-off-by: Zeynel Koca <[email protected]>
67c7712 to
15b4e9d
Compare
|
@sicoyle No formatting issues anymore 🎉 1 failing unit test though, which I updated based on the new TTL property behavior. All tests pass now locally |
Signed-off-by: Zeynel Koca <[email protected]>
15b4e9d to
eb01fff
Compare
Description
Adds a way to globally configure the state TTL for dynamo (inspired by #1059).
The defined default TTL will only be used if the state request does not explicitly specify a TTL itself.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: