dapp: remappings: document new format, rename & expose legacy compat …

…flag
dapphub · Sep 8, 2021 · 35fa490 · 35fa490
1 parent 5a6ef96
commit 35fa490
Show file tree

Hide file tree

Showing 5 changed files with 311 additions and 150 deletions.
diff --git a/src/dapp-tests/integration/tests.sh b/src/dapp-tests/integration/tests.sh
@@ -63,13 +63,12 @@ dapp_remappings() {
 
 dapp_remappings
 
-# tests dapp remappings on a large legacy project with many implicit imports
+# tests dapp remappings on a large legacy project with many transitive imports
 dapp_remappings_compat() {
     REV="bc6d7657f0f5190f65051543199e1b47bf29932b"
     TMPDIR=$(mktemp -d)
     git clone https://github.com/dapp-org/tinlake-tests "$TMPDIR"
-    export DAPP_ALLOW_IMPLICIT_IMPORTS=yes
-    (cd "$TMPDIR" && git checkout "$REV" && dapp update && dapp --use solc:0.7.6 build)
+    (cd "$TMPDIR" && git checkout "$REV" && dapp update && dapp --use solc:0.7.6 build --allow-transitive-imports)
 }
 
 dapp_remappings_compat

diff --git a/src/dapp/CHANGELOG.md b/src/dapp/CHANGELOG.md
@@ -11,11 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - `DAPP_TEST_DEPTH` env var to control `--depth`
 - `--coverage` flag for `dapp test` to generate coverage via hevm
-- `dapp debug` respects the `DAPP_LINK_TEST_LIBRARIES` environment variable.
 
 ### Changed
 
-- Dapp debug respects DAPP_LINK_TEST_LIBRARIES 
+- `dapp debug` respects the `DAPP_LINK_TEST_LIBRARIES` environment variable.
 
 ### Fixed
 
@@ -27,9 +26,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - `hevm` bumped to london hard fork.
 - `dapp --use` now uses the solc binaries from https://binaries.soliditylang.org/ instead of the
-  versions built from source via nix
-- `dapp remappings` now issues a warning instead of failing with a hard error in case of mistmatched
-  package versions in the dependency tree
+    versions built from source via nix
+- `dapp remappings` now generates a unique set of remappings for each package in the dependency
+    tree that point into that pacakge's lib dir, allowing for multiple versions of the same package
+    to coexist in the dependency tree. More information in the [README](./README.md#package-structure-and-dependency-management).
 
 ## [0.33.0] - 2021-07-01