Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addresses #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix addresses #13

wants to merge 3 commits into from

Conversation

livnev
Copy link
Member

@livnev livnev commented Apr 1, 2020

@MrChico permit tests are now broken, since hevm addresses have changed. I changed the constants in bin/conf/hevm.sh, but now the tests need to be changed (r, s, need to be recomputed, I think).

the way that hevm computes addresses of deployed contracts was changed
in a recent version, fixing an outstanding bug.
@livnev livnev requested a review from MrChico April 1, 2020 20:30
@livnev
Copy link
Member Author

livnev commented Apr 1, 2020

This fixes #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants