Aio pika ack request early #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first version implemented.
some minor fixes.
some unit tests added.
some bugs fixed
refactoring and some improvements.
middleware and tracing support.
some trash removed.
- pydantic schema generation bug fixed - method registry merge implementation changed
specification generation implemented - openapi specification generation implemented - openrpc specification generation implemented - web ui support added (SwaggerUI, RapiDoc, ReDoc)
- pytest integration bug fixed - ViewMethod copy bug fixed - pydantic required version increased - openapi/openrpc specification definitions support implemented
- starlette integration added - django integration added - sub endpoints support implemented
- openapi jsonrpc request schema fixed
- openapi dataclass alias setting bug fixed.
- request and response loggers separated. - alternative json-rpc content types support added.
- sphinx-doc version locked
- openapi error examples support added. - openapi errors schema support added. - multiple extractors support added. - docstring extractor bug fixed.
- python 3.10 support added - pipenv replaced by poetry - mypy type checker added - kombu client hanging bug fixed - openapi json-rpc versions reordered so that version 2.0 will be the default example version - set_default_content_type function exposed - documentation fixed
- JSON-RPC client requests retry support added - aio-pika integration and backend updated for aio-pika 8.0 - type aliases for middlewares added - httpx minimal version updated due to found vulnerability
- refactoring done - dependencies updated - python 3.11 support added
- pydantic 2 support added
- client headers passing bug fixed.
- openapi schema generation bug fixed.
- aiohttp client uses request context manager.
- aio-pika custom response exchange support added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @dapper91,
Thank you for merging our last adjustments already. It works just as smooth as expected.
While testing, we found an issue with the aio_pika backend. In case a rpc method causes an application crash, the request message won't be acknowledged and thus may be reissued, depending on the rabbit mq config, at the next appliaction start which leads the application to end up in a crash and restart loop.
With the proposed adjustment, the request message is acknowledged before execution of the rpc method which prevents the above situation.
I'd really appreciate if you could also merge this adjustment anytime soon.
Thanks and best regards,
Julian