Conversation
janekmi
left a comment
There was a problem hiding this comment.
@janekmi reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @grom72 and @osalyk).
src/test/pmempool_sync/TEST43 line 59 at r1 (raw file):
create_recovery_file $DIR/testset1_r1_p2_badblocks.txt turn_on_checking_bad_blocks $POOLSET
Can we remove all of these in one go?
osalyk
left a comment
There was a problem hiding this comment.
@osalyk made 1 comment.
Reviewable status: 0 of 16 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi).
src/test/pmempool_sync/TEST43 line 59 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
Can we remove all of these in one go?
Done.
janekmi
left a comment
There was a problem hiding this comment.
@janekmi reviewed 16 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @grom72).
a discussion (no related file):
Whoever will merge this it would be good to mention #28 in the commit message.
grom72
left a comment
There was a problem hiding this comment.
@grom72 made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @osalyk).
a discussion (no related file):
Previously, janekmi (Jan Michalski) wrote…
Whoever will merge this it would be good to mention #28 in the commit message.
So this should be added to the commit message.
janekmi
left a comment
There was a problem hiding this comment.
@janekmi made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @osalyk).
a discussion (no related file):
Previously, grom72 (Tomasz Gromadzki) wrote…
So this should be added to the commit message.
Yes. But it can be done while squashing.
Done. |
janekmi
left a comment
There was a problem hiding this comment.
@janekmi reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @osalyk).
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
janekmi
left a comment
There was a problem hiding this comment.
@janekmi reviewed 30 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @osalyk).
grom72
left a comment
There was a problem hiding this comment.
@grom72 reviewed 30 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @osalyk).
grom72
left a comment
There was a problem hiding this comment.
@grom72 made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @osalyk).
grom72
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @osalyk).
This change is