Conversation
osalyk
force-pushed
the
shutdown_state_check
branch
3 times, most recently
from
603867f to
fe605f1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
osalyk
force-pushed
the
shutdown_state_check
branch
2 times, most recently
from
8f1dacd to
f8d79b1
Compare
osalyk
force-pushed
the
shutdown_state_check
branch
from
f8d79b1 to
86285c3
Compare
osalyk
force-pushed
the
shutdown_state_check
branch
from
86285c3 to
f71cac3
Compare
osalyk
force-pushed
the
shutdown_state_check
branch
4 times, most recently
from
4cfd72e to
f339433
Compare
osalyk
force-pushed
the
shutdown_state_check
branch
2 times, most recently
from
0279a3a to
50deb67
Compare
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk
force-pushed
the
shutdown_state_check
branch
from
50deb67 to
0652d7c
Compare
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk
force-pushed
the
shutdown_state_check
branch
from
8767ec4 to
99818ca
Compare
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
janekmi
left a comment
janekmi
left a comment
There was a problem hiding this comment.
You may also want to take a look at the core_log_max test to make sure it is up to date.
It is generated by utils/call_stack_analysis/log_call_all_generate.py.
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
everything is fine |
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
src/common/shutdown_state.c
Outdated
| if (is_uuid_correct) | ||
| CORE_LOG_WARNING( | ||
| "The ADR failure was detected but the pool was closed - the ADR failure detection will be reinitialized."); | ||
| "The ADR failure was detected but the pool was closed properly - the ADR failure detection will be reinitialized."); |
There was a problem hiding this comment.
Please apply consistently. xD Instead of:
- the ADR failure detection will be reinitialized x2
- reinitializing the ADR failure detection
please use "reinitializing ADR failure detection". Because:
- All of these indicate exactly the same outcome.
- I believe without "the" it sounds a little bit more natural. Sorry for the last minute change.
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
src/common/shutdown_state.c
Outdated
| /* the program was killed during opening or closing the pool */ | ||
| CORE_LOG_WARNING( | ||
| "incorrect checksum - SDS will be reinitialized"); | ||
| "Incorrect checksum - reinitializing ADR failure detection."); |
There was a problem hiding this comment.
The pool was not opened/closed properly - reinitializing ADR failure detection.
grom72
left a comment
grom72
left a comment
There was a problem hiding this comment.
Reviewed 1 of 7 files at r3.
Reviewable status: 1 of 74 files reviewed, 84 unresolved discussions
janekmi
left a comment
janekmi
left a comment
There was a problem hiding this comment.
Reviewed 1 of 6 files at r2, 7 of 7 files at r3, all commit messages.
Reviewable status: 8 of 74 files reviewed, 84 unresolved discussions
osalyk
left a comment
osalyk
left a comment
There was a problem hiding this comment.
Reviewable status: 8 of 74 files reviewed, 84 unresolved discussions
osalyk
left a comment
osalyk
left a comment
There was a problem hiding this comment.
Reviewable status: 8 of 74 files reviewed, 84 unresolved discussions
+ minor adjustments to error/warning messages Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
3 participants
Reviewable is still better for browsing. You can't publish your review at the moment though.
Ref: https://reviewable.io/reviews/daos-stack/pmdk/1
This change is