Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing a clickable link to a site report Permalink #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

edjw
Copy link

@edjw edjw commented Mar 7, 2019

When I check a URL on the Blocked frontend, I find I often want to open the permalink in a new tab. This takes longer than it should at the moment.

This is what the interface currently looks like. You have to know what the copy to clipboard symbol means, click on it, then click in the address bar, then tap enter. It's not clear why this would be a form rather than a link.

screenshot 2019-03-07 at 11 57 10

My PR would mean the user only has to be able to recognise a link and click on it to get to the permalink.

screenshot 2019-03-07 at 12 02 09

Copy link
Owner

@dantheta dantheta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the replacement template block removes the templated elements under "Related results", replacing it with static content. The changes to the blocked-eu version of the page similarly insert an extra copy of the category information with hard-coded values.

The replacement of the form-horizontal element is fine though, so the change should be trimmed down to just replace that part of the template.

The javascript for the copy-clipboard button is looking for an element with the id permalink in order to select and clipboard-copy it. The ID can probably be applied to the small element or the enclosed a element.

Hope that's OK - thanks for sending the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants