-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TeamDrive functionality #67
base: master
Are you sure you want to change the base?
Conversation
added the key supportsTeamDrives: True
add teamdrive option
Fixes #61 |
Code: LGTM but could you please change the
|
@@ -7,7 +7,8 @@ var defaults = require('../defaults'); | |||
var manifestor = require('../manifestor'); | |||
var authenticate = require('../authenticate'); | |||
|
|||
module.exports = function upload() { | |||
module.exports = function upload(options) { | |||
// console.log(options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean this ? :)
@@ -48,6 +48,12 @@ function sendToGoogle(files, id) { | |||
} | |||
}; | |||
|
|||
if (supportsTeamDrives) { | |||
console.log('teamdrive=true') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about editing the message that shows up when uploading (something like "Pushing back up to Google Drive (target project is inside a Team Drive)..."?
@@ -1,3 +1,24 @@ | |||
The branch works for scripts sitting in a Team Drive by adding the parameter supportsTeamDrives to the upload request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't say better than @lricoy comment about updating the README
The branch works for scripts sitting in a Team Drive by adding the parameter supportsTeamDrives to the upload request.
supportTeamDrives
set to true, see https://developers.google.com/apis-explorer/?hl=en_US#p/drive/v3/drive.files.update and https://developers.google.com/drive/v3/reference/files/updatesupportsTeamDrives: true
tofixes the problem for a team drive
I've added this as an addition option. I.e.