Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamDrive functionality #67

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

tonyOreglia
Copy link

The branch works for scripts sitting in a Team Drive by adding the parameter supportsTeamDrives to the upload request.

fixes the problem for a team drive

I've added this as an addition option. I.e.

gapps push --teamdrive 

@lricoy
Copy link
Collaborator

lricoy commented Nov 29, 2017

Fixes #61

@lricoy
Copy link
Collaborator

lricoy commented Nov 29, 2017

Code: LGTM but could you please change the README in order to:

  • Include the new option under the Docs section for the upload command.
  • Add a item in the Common Issues section with your comments about Team Drive
  • Fix conflicts :)

@@ -7,7 +7,8 @@ var defaults = require('../defaults');
var manifestor = require('../manifestor');
var authenticate = require('../authenticate');

module.exports = function upload() {
module.exports = function upload(options) {
// console.log(options)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean this ? :)

@@ -48,6 +48,12 @@ function sendToGoogle(files, id) {
}
};

if (supportsTeamDrives) {
console.log('teamdrive=true')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about editing the message that shows up when uploading (something like "Pushing back up to Google Drive (target project is inside a Team Drive)..."?

@@ -1,3 +1,24 @@
The branch works for scripts sitting in a Team Drive by adding the parameter supportsTeamDrives to the upload request.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't say better than @lricoy comment about updating the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants