Skip to content

fix(security): bind to localhost by default #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bkrabach wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(security): bind to localhost by default #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,18 +590,27 @@ async function main() {
}

const port = Number(process.env.PORT || 3001)
server.listen(port, '0.0.0.0', () => {
log.info({ port, appVersion: APP_VERSION }, 'Server listening')
const host = process.env.HOST || '127.0.0.1' // Default to localhost for safety
server.listen(port, host, () => {
log.info({ port, host, appVersion: APP_VERSION }, 'Server listening')

// Print friendly startup message
const token = process.env.AUTH_TOKEN
const lanIps = detectLanIps()
const lanIp = lanIps[0] || 'localhost'
const url = `http://${lanIp}:${port}/?token=${token}`
const isDev = process.env.NODE_ENV !== 'production'
const frontendPort = isDev ? (process.env.VITE_PORT || '5173') : port
const networkUrl = `http://${lanIp}:${frontendPort}/?token=${token}`
const localUrl = `http://localhost:${frontendPort}/?token=${token}`

console.log('')
console.log(`\x1b[32m\u{1F41A}\u{1F525} freshell is ready!\x1b[0m`)
console.log(` Visit from anywhere on your network: \x1b[36m${url}\x1b[0m`)
if (host === '127.0.0.1' || host === 'localhost') {
console.log(` Local only: \x1b[36m${localUrl}\x1b[0m`)
console.log(` \x1b[33m(Set HOST=0.0.0.0 to expose to network)\x1b[0m`)
} else {
console.log(` Visit from anywhere on your network: \x1b[36m${networkUrl}\x1b[0m`)
}
console.log('')

startBackgroundTasks()
Expand Down
2 changes: 1 addition & 1 deletion vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default defineConfig(({ mode }) => {
sourcemap: mode === 'development',
},
server: {
host: true,
host: env.VITE_HOST || '127.0.0.1', // Default to localhost for safety
port: vitePort,
watch: {
ignored: ['**/.worktrees/**', '**/demo-projects/**'],
Expand Down