-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
🔑 feat: Add support for users to be admins when logging in using OpenID #9170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jpsfs
wants to merge
8
commits into
danny-avila:dev
Choose a base branch
from
jpsfs:dev/openid-admin
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks, please address ESLint issues |
@danny-avila Run lint:fix and pushed it again. Couldn't understand most of initial errors. |
@danny-avila know I think it's all :) |
Very cool, I think this makes a lot of sense as alternative and would be a neat upgrade from the current version (first user receives update) |
Hi @danny-avila ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Summary
This Pull Request implements #9167 .
The goal is to allow a user that logins OIDC to be an admin in LibreChat depending on a claim that can exist in either the access_token, id_token or it's user profile.
A PR for the documentation was also open, detailing 3 new env vars, similar to the ones already used to check required roles.
Change Type
Please delete any irrelevant options.
Testing
Depending on your OIDC provider configurations might be different.
If you have a claim in the
id_token
calledroles
that's an array, and an admin user must have a role called admin, the configuration would be the following:Test Configuration:
Checklist
Please delete any irrelevant options.